Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both deflate and gzip #15

Merged
merged 4 commits into from Mar 10, 2013
Merged

Support both deflate and gzip #15

merged 4 commits into from Mar 10, 2013

Conversation

Swaagie
Copy link
Contributor

@Swaagie Swaagie commented Mar 10, 2013

required tests for #write added, fixes #11

As far as I could tell using Nock for these tests was a no go, since nock only handles the client side of requesting. Write is mostly about server internals

@3rd-Eden
Copy link
Owner

Sweet, i'll review it tinight. Thanks for all your hard work

Twitter: @3rdeden
Github: @3rd-Eden

On Sun, Mar 10, 2013 at 2:48 PM, Martijn Swaagman
notifications@github.com wrote:

required tests for #write added, fixes #11
As far as I could tell using Nock for these tests was a no go, since nock only handles the client side of requesting. Write is mostly about server internals
You can merge this Pull Request by running:
git pull https://github.com/Swaagie/versions master
Or you can view, comment on it, or merge it online at:
#15
-- Commit Summary --

3rd-Eden added a commit that referenced this pull request Mar 10, 2013
Support both deflate and gzip
@3rd-Eden 3rd-Eden merged commit 0fa17c2 into 3rd-Eden:master Mar 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache deflate/gzip separatly
2 participants